Re: [PATCH bpf-next v4 2/2] bpf: Add show_fdinfo for kprobe_multi

[Alexei Starovoitov]

On Wed, Jun 18, 2025 at 8:44 PM Tao Chen <chen.dylane@xxxxxxxxx> wrote:
>
> Show kprobe_multi link info with fdinfo, the info as follows:
>
> link_type:      kprobe_multi
> link_id:        1
> prog_tag:       a15b7646cb7f3322
> prog_id:        21
> type:   kprobe_multi

..

> +       seq_printf(seq,
> +                  "type:\t%s\n"
> +                  "kprobe_cnt:\t%u\n"
> +                  "missed:\t%lu\n",
> +                  kmulti_link->flags == BPF_F_KPROBE_MULTI_RETURN ? "kretprobe_multi" :
> +                                        "kprobe_multi",

why print the same info twice ?
seq_printf(m, "link_type:\t%s\n", bpf_link_type_strs[type]);
in bpf_link_show_fdinfo() already did it in a cleaner way.

Same issue in the other patch.

pw-bot: cr