Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark
From: Mina Almasry
Date: Thu Jun 19 2025 - 13:06:08 EST
On Thu, Jun 19, 2025 at 9:58 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Thu, 19 Jun 2025 08:37:05 -0700 Mina Almasry wrote:
> > Jakub, this patch was marked 'changes requested' for good reason, but
> > after investigation we found the patch itself is good and the issues
> > were elsewhere. What do I do here? A resend of v4? Or does this un
> > 'changes requested' as-is?
>
> Do you want to update the numbers in the commit msg?
Oh, I thought it's fine as-is. I can update them if need be, no need
to trouble yourself. I'll upload v5 with updated benchmark results +
make a note on how to cross build it (specify the KDIR= arg).
--
Thanks,
Mina