Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

From: Matthew Wilcox
Date: Thu Jun 19 2025 - 12:04:14 EST


On Wed, Jun 18, 2025 at 11:29:31AM +0000, Shivank Garg wrote:
> From: Shivansh Dhiman <shivansh.dhiman@xxxxxxx>
>
> Add NUMA mempolicy support to the filemap allocation path by introducing
> new APIs that take a mempolicy argument:
> - filemap_grab_folio_mpol()
> - filemap_alloc_folio_mpol()
> - __filemap_get_folio_mpol()

You don't use these APIs in this series, so I can't evaludate whether
any of my suggestiosn for improving this patch would actually work.
NACK. Introduce the APIs *with a user*. Come on, this isn't a new
requirement.