Re: [PATCH 1/6] staging: sm750fb: rename `sBase` parameter
From: Greg KH
Date: Thu Jun 19 2025 - 11:32:31 EST
On Tue, May 27, 2025 at 10:11:23AM -0700, Eric Florin wrote:
> Rename `sBase` to `s_base` in `sm750_hw_copyarea` to conform with style
> guidelines as reported by checkpatch.pl
>
> CHECK: Avoid CamelCase: <sBase>
>
> Signed-off-by: Eric Florin <ericflorin@xxxxxxxxxx>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..74e4be8103ac 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -132,7 +132,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> /**
> * sm750_hw_copyarea
> * @accel: Acceleration device data
> - * @sBase: Address of source: offset in frame buffer
> + * @s_base: Address of source: offset in frame buffer
Wouldn't a better name be "source_base"?
thanks,
greg k-h