Re: [PATCH v2 2/6] mfd: spacemit: add support for SpacemiT PMICs

[Lee Jones]

On Thu, 19 Jun 2025, Alex Elder wrote:

> Add support for SpacemiT PMICs. Initially only the P1 PMIC is supported
> but the driver is structured to allow support for others to be added.
> 
> The P1 PMIC is controlled by I2C, and is normally implemented with the
> SpacemiT K1 SoC.  This PMIC provides six buck converters and 12 LDO
> regulators.  It also implements a switch, watchdog timer, real-time clock,
> and more, but initially we will only support its regulators.
> 
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
> ---
> v2: - Use module_i2c_driver()
>     - Expanded Kconfig module help text
>     - Add MODULE_ALIAS(), and define and use DRV_NAME
> 
>  drivers/mfd/Kconfig         | 13 ++++++
>  drivers/mfd/Makefile        |  1 +
>  drivers/mfd/spacemit-pmic.c | 83 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 97 insertions(+)
>  create mode 100644 drivers/mfd/spacemit-pmic.c

All comments fro v1 are still relevant.

-- 
Lee Jones [李琼斯]