Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check

[Bui Quang Minh]

On 6/19/25 09:11, Jakub Kicinski wrote:
> On Sun, 15 Jun 2025 22:13:32 +0700 Bui Quang Minh wrote:
> > +/**
> > + * buf_to_xdp() - convert the @buf context to xdp_buff
> > + * @vi: virtnet_info struct
> > + * @rq: the receive queue struct
> > + * @buf: the xdp_buff pointer that is passed to virtqueue_add_inbuf_premapped in
> > + *       virtnet_add_recvbuf_xsk
> > + * @len: the length of received data without virtio header's length
> > + * @first_buf: this buffer is the first one or not
> > + */
> >   static struct xdp_buff *buf_to_xdp(struct virtnet_info *vi,
> > -				   struct receive_queue *rq, void *buf, u32 len)
> > +				   struct receive_queue *rq, void *buf,
> > +				   u32 len, bool first_buf)
> I think Michael mention he's AFK so while we wait could you fix this
> kdoc? I'm not sure whether the kdoc is really necessary here, but if
> you want to keep it you have to document the return value:
>
> Warning: drivers/net/virtio_net.c:1141 No description found for return value of 'buf_to_xdp'

I want to add kdoc to clarify that the @len must be without virtio 
header's length. I'll fix it in the next version.

Thanks,
Quang Minh.