Re: [PATCH v5 3/8] pmdomain: thead: Instantiate GPU power sequencer via auxiliary bus
From: Ulf Hansson
Date: Thu Jun 19 2025 - 10:05:55 EST
On Thu, 19 Jun 2025 at 14:31, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Thu, Jun 19, 2025 at 12:25 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> >
> > On Wed, 18 Jun 2025 at 12:22, Michal Wilczynski
> > <m.wilczynski@xxxxxxxxxxx> wrote:
> > >
> > > In order to support the complex power sequencing required by the TH1520
> > > GPU, the AON power domain driver must be responsible for initiating the
> > > corresponding sequencer driver. This functionality is specific to
> > > platforms where the GPU power sequencing hardware is controlled by the
> > > AON block.
> > >
> > > Extend the AON power domain driver to check for the presence of the
> > > "gpu-clkgen" reset in its own device tree node.
> > >
> > > If the property is found, create and register a new auxiliary device.
> > > This device acts as a proxy that allows the dedicated `pwrseq-thead-gpu`
> > > auxiliary driver to bind and take control of the sequencing logic.
> > >
> > > Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> >
> > Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> >
> > It looks like there is another re-spin needed, but thinking of the
> > merge-strategy I could potentially take patch1->patch3 via my pmdomain
> > tree, as it seems reasonable to keep those changes together. Unless
> > Bartosz sees any problem with that, of course.
> >
>
> I have another change planned for the pwrseq API for this cycle.
> Nothing major but it still will require patch 1/8 to be in my tree so
> if you don't mind, I'll take it hrough the pwrseq tree and provide you
> an immutable tag to pull before you apply the rest?
Right, that works perfectly fine too. I will wait for you to give me
the branch then, before applying anything.
Kind regards
Uffe