Re: [PATCH] Various improvements on clock abstractions
From: Alexandre Courbot
Date: Thu Jun 19 2025 - 09:48:40 EST
On Thu Jun 19, 2025 at 7:05 PM JST, Onur wrote:
> On Thu, 19 Jun 2025 12:15:34 +0530
> Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
>> On 17-06-25, 08:55, Miguel Ojeda wrote:
>> > On Tue, Jun 17, 2025 at 6:28 AM Onur Özkan <work@xxxxxxxxxxxxx>
>> > wrote:
>> > >
>> > > Yes, it should be "Onur Özkan", sorry. Should I update that part
>> > > and re-send the patch?
>> >
>> > I would suggest to wait for other feedback, and then you can send a
>> > v2 if needed.
>> >
>> > > where my patch converts this into a single straight line which I
>> > > think makes it more idiomatic.
>> >
>> > Up to the maintainers :) So far we have both styles around.
>>
>> I am okay with all the changes, the commit log can be improved as you
>> mentioned earlier.
>>
>> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>>
>
> FWIW I split this patch into 3 parts and sent them separately as it
> was suggested earlier by Alexandre.
>
> Here are the patches I sent yesterday:
>
> - https://lore.kernel.org/all/20250618092810.29370-1-work@xxxxxxxxxxxxx/
> - https://lore.kernel.org/all/20250618093508.16343-1-work@xxxxxxxxxxxxx/
> - https://lore.kernel.org/all/20250618091442.29104-1-work@xxxxxxxxxxxxx/
These look good! Small nit for next time: since they are closely
related, please send them as a series to make review (and merging, as
they will conflict if not applied in the right order) easier.