Re: [PATCH 1/6] dt-bindings: mfd: add support the SpacmiT P1 PMIC

[Alex Elder]

On 6/19/25 1:03 AM, Vivian Wang wrote:
> Hi Alex,
>
> Before the patch body, there's a typo in the subject line: "SpacmiT" ->
> "SpacemiT".

Thank you, I will fix that in v2, which I plan to post today.

					-Alex

> On 6/14/25 05:01, Alex Elder wrote:
> > Enable the SpacemiT P1, which is an I2C-controlled PMIC.  Initially we
> > only the regulators will be supported.
> >
> > Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mfd/spacemit,p1.yaml  | 86 +++++++++++++++++++
> >   1 file changed, 86 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/mfd/spacemit,p1.yaml
> >
> > <snip>
> >
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pmic@41 {
> > +            compatible = "spacemit,p1";
> > +            reg = <0x41>;
> > +            interrupts = <64>;
> > +
>
> (Not really a review, just a note.)
>
> I couldn't believe it at first, but it looks like the SpacemiT K1 really
> does have PLIC interrupt 64 dedicated to receiving PMIC interrupt [1]
> over pin "PMIC_INT_N".
>
> Regards,
> Vivian "dramforever" Wang
>
> [1]: https://developer.spacemit.com/documentation?token=AZsXwVrqaisaDGkUqMWcNuMVnPb
>
> > <snip>