Re: [PATCH v2] usbip: convert to use faux_device

From: Greg KH
Date: Thu Jun 19 2025 - 07:02:31 EST


On Tue, Jun 10, 2025 at 09:15:51AM -0600, Shuah Khan wrote:
> On 6/4/25 00:54, Zongmin Zhou wrote:
> > From: Zongmin Zhou <zhouzongmin@xxxxxxxxxx>
> >
> > The vhci driver does not need to create a platform device,
> > it only did so because it was simple to do that in order to
> > get a place in sysfs to hang some device-specific attributes.
> > Now the faux device interface is more appropriate,change it
> > over to use the faux bus instead.
> >
> > Signed-off-by: Zongmin Zhou <zhouzongmin@xxxxxxxxxx>
> > ---
> > Changes in v2:
> > - don't change faux create api,just call probe on vhci_hcd_init.
>
> I will defer the review to Greg on this.
>
> I am fine with the change if Greg is happy with it. :)

Well the build errors aren't that good, but overall, yes, it's a nice
change :)

thanks,

greg k-h