Re: [PATCH] md/raid1: change r1conf->r1bio_pool to a pointer type

From: Yu Kuai
Date: Thu Jun 19 2025 - 05:08:51 EST


Hi,

在 2025/06/18 19:41, Wang Jinchao 写道:
In raid1_reshape(), newpool is a stack variable.
mempool_init() initializes newpool->wait with the stack address.
After assigning newpool to conf->r1bio_pool, the wait queue
need to be reinitialized, which is not ideal.

Change raid1_conf->r1bio_pool to a pointer type and
replace mempool_init() with mempool_create() to
avoid referencing a stack-based wait queue.

Can you also switch to kmalloc pool in this patch?

Thanks,
Kuai