Re: [PATCH v10 03/14] unwind_user: Add compat mode frame pointer support

From: Peter Zijlstra
Date: Thu Jun 19 2025 - 03:51:23 EST


On Wed, Jun 18, 2025 at 11:18:40AM -0400, Steven Rostedt wrote:
> On Wed, 18 Jun 2025 15:47:58 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > On Tue, Jun 10, 2025 at 08:54:24PM -0400, Steven Rostedt wrote:
> >
> > > +#ifndef arch_unwind_user_init
> > > +static inline void arch_unwind_user_init(struct unwind_user_state *state, struct pt_regs *reg) {}
> > > +#endif
> > > +
> > > +#ifndef arch_unwind_user_next
> > > +static inline void arch_unwind_user_next(struct unwind_user_state *state) {}
> > > +#endif
> >
> > The purpose of these arch hooks is so far mysterious. No comments, no
> > changelog, no nothing.
>
> I'll add comments.

How about you introduce the hooks when they're actually needed instead?