Re: [PATCH v12 1/6] rust: enable `clippy::ptr_as_ptr` lint

From: Viresh Kumar
Date: Thu Jun 19 2025 - 01:54:34 EST


On 18-06-25, 18:48, Miguel Ojeda wrote:
> On Sun, Jun 15, 2025 at 10:55 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > Apply these changes and enable the lint -- no functional change
> > intended.
>
> We need one more for `opp` [1] -- Viresh: I can do it on apply, unless
> you disagree.

Please do. Thanks.

> diff --git a/rust/kernel/opp.rs b/rust/kernel/opp.rs
> index a566fc3e7dcb..bc82a85ca883 100644
> --- a/rust/kernel/opp.rs
> +++ b/rust/kernel/opp.rs
> @@ -92,7 +92,7 @@ fn to_c_str_array(names: &[CString]) ->
> Result<KVec<*const u8>> {
> let mut list = KVec::with_capacity(names.len() + 1, GFP_KERNEL)?;
>
> for name in names.iter() {
> - list.push(name.as_ptr() as _, GFP_KERNEL)?;
> + list.push(name.as_ptr().cast(), GFP_KERNEL)?;
> }
>
> list.push(ptr::null(), GFP_KERNEL)?;

For cpufreq/opp:

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh