[PATCH] sched/fair: set the se->vlag strictly following the paper
From: Huang Shijie
Date: Wed Jun 18 2025 - 23:20:33 EST
>From the paper, the lag should follow the limit:
-r_max < lag < max(r_max, q)
But current code makes the lag follow the limit:
-max(r_max, q) < lag < max(r_max, q)
This patch introduces limit_hi/limit_lo/r_max, and
make the lag follow the paper strictly.
Signed-off-by: Huang Shijie <shijie@xxxxxxxxxxxxxxxxxxxxxx>
---
kernel/sched/fair.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 83157de5b808..102d263df330 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -694,14 +694,17 @@ u64 avg_vruntime(struct cfs_rq *cfs_rq)
*/
static void update_entity_lag(struct cfs_rq *cfs_rq, struct sched_entity *se)
{
- s64 vlag, limit;
+ s64 vlag, limit_hi, limit_lo, r_max;
WARN_ON_ONCE(!se->on_rq);
vlag = avg_vruntime(cfs_rq) - se->vruntime;
- limit = calc_delta_fair(max_t(u64, 2*se->slice, TICK_NSEC), se);
+ r_max = 2 * se->slice;
- se->vlag = clamp(vlag, -limit, limit);
+ limit_hi = calc_delta_fair(max_t(u64, r_max, TICK_NSEC), se);
+ limit_lo = calc_delta_fair(r_max, se);
+
+ se->vlag = clamp(vlag, -limit_lo, limit_hi);
}
/*
--
2.40.1