RE: [PATCH 0/4] mmc: rtsx_usb_sdmmc: Improve sd_set_power_mode()

[Ricky WU]

> -----Original Message-----
> From: Ricky WU
> Sent: Wednesday, June 18, 2025 10:48 AM
> To: 'Ulf Hansson' <ulf.hansson@xxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH 0/4] mmc: rtsx_usb_sdmmc: Improve
> sd_set_power_mode()
> 
> > On Tue, 10 Jun 2025 at 13:16, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> > >
> > > The code in sd_set_power_mode() is a bit obfuscated and also has
> > > some minor issue in its error-path. This small series addresses these
> problems.
> > >
> > > Ulf Hansson (4):
> > >   mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode()
> > >   mmc: rtsx_usb_sdmmc: Print debug-messages at power-on/off errors
> > >   mmc: rtsx_usb_sdmmc: Convert sd_set_power_mode() into void
> > >   mmc: rtsx_usb_sdmmc: Re-work the code in sd_set_power_mode()
> > >
> > >  drivers/mmc/host/rtsx_usb_sdmmc.c | 31
> > > ++++++++++++++++++++-----------
> > >  1 file changed, 20 insertions(+), 11 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> >
> > Ricky, I would appreciate your feedback on these too. Or at least an ack.
> 
> Hi Ulf,
> Sorry, I forgot to reply this patch,
> This patch is fine for me, and this also work well Thank you
> 
Acked-by: Ricky Wu <ricky_wu@xxxxxxxxxxx>
> 
> >
> > Kind regards
> > Uffe