[PATCH] usb: host: xhci-plat: fix incorrect type for of_match variable in xhci_plat_probe()
From: Seungjin Bae
Date: Wed Jun 18 2025 - 15:50:58 EST
From: pip-izony <eeodqql09@xxxxxxxxx>
The variable `of_match` was incorrectly declared as a `bool`.
It is assigned the return value of of_match_device(), which is a pointer of
type `const struct of_device_id *`.
Fixes: 16b7e0cccb243 ("USB: xhci-plat: fix legacy PHY double init")
Signed-off-by: Seungjin Bae <eeodqql09@xxxxxxxxx>
---
drivers/usb/host/xhci-plat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 6dab142e7278..49eb874b1d81 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -152,7 +152,7 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
int ret;
int irq;
struct xhci_plat_priv *priv = NULL;
- bool of_match;
+ const struct of_device_id *of_match;
if (usb_disabled())
return -ENODEV;
--
2.43.0
Hello Greg,
Thank you for your review and the helpful feedback.
I've corrected Signed-off-by line to use my real name.
I also updated Fixes tag in the commit.
Regarding the original issue:
I'm not exactly sure why the compiler didn't catch this,
but I assume implicit casting from pointer to bool is allowed in this context.
Thank you for your email!
Best regards,
Seungjin Bae