Re: [PATCH] platform: cznic: turris-omnia-mcu: Use new GPIO line value setter callbacks

[Marek Behún]

On Wed, Jun 18, 2025 at 08:47:33PM +0200, Marek Behún wrote:
> On Wed, Jun 18, 2025 at 03:20:15PM +0200, Bartosz Golaszewski wrote:
> > On Wed, Jun 18, 2025 at 2:43 PM Marek Behún <kabel@xxxxxxxxxx> wrote:
> > >
> > > struct gpio_chip now has callbacks for setting line values that return
> > > an integer, allowing to indicate failures. Convert the driver to using
> > > them.
> > >
> > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> > > ---
> > 
> > What's going on with this patch? I sent it a few days ago, now you
> > just resent it without changes. Who should pick it up?
> 
> I didn't see any patch for this driver, only for gpio-moxtet (for which
> I sent R-b). Did I overlook it?

OMG I see it now. Sorry.

There is one difference, though. Your change makes omnia_gpio_set() return
-EINVAL on a GPIO that does not support output direction. I put -ENOTSUPP
there, since -ENOTSUPP is also returned by direction_input() and
direction_output() methods in this case.

I don't know if -EINVAL or -ENOTSUPP is more consistent, though. Feel free
to apply your version (you can also add my R-b tag).

Marek