RE: [PATCH] scsi: fnic: fix missing dma mapping error in `fnic_send_frame()`

[Karan Tilak Kumar (kartilak)]

On Tuesday, June 17, 2025 11:57 PM, Thomas Fourier <fourier.thomas@xxxxxxxxx> wrote:
>
> `dma_map_XXX()` can fail and should be tested for errors with
> `dma_mapping_error().`
>
> Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")
> Signed-off-by: Thomas Fourier <fourier.thomas@xxxxxxxxx>
> ---
> drivers/scsi/fnic/fnic_fcs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
> index 1e8cd64f9a5c..103ab6f1f7cd 100644
> --- a/drivers/scsi/fnic/fnic_fcs.c
> +++ b/drivers/scsi/fnic/fnic_fcs.c
> @@ -636,6 +636,8 @@ static int fnic_send_frame(struct fnic *fnic, void *frame, int frame_len)
> unsigned long flags;
>
> pa = dma_map_single(&fnic->pdev->dev, frame, frame_len, DMA_TO_DEVICE);
> +     if (dma_mapping_error(&fnic->pdev->dev, pa))
> +             return -ENOMEM;
>
> if ((fnic_fc_trace_set_data(fnic->fnic_num,
> FNIC_FC_SEND | 0x80, (char *) frame,
> --
> 2.43.0
>
>

Looks good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>

Regards,
Karan