Re: [PATCH] media: vsp1: Add missing export.h

[Laurent Pinchart]

Hi Jacopo,

On Wed, Jun 18, 2025 at 05:42:47PM +0200, Jacopo Mondi wrote:
> As reported by the Kernel Test Robot, the newly merged vspx driver
> exports a few symbols but doesn't include the export.h header.
> 
> While at it, include the header file in vsp1_drm.c which exports
> symbols as well.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506181950.r9PRdV59-lkp@xxxxxxxxx/
> Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
> Add missing export.h header as reported by kernel test robot <lkp@xxxxxxxxx>
> 
> Can this patch be fast-tracked to ensure it lands with the one that
> introduces the vspx driver ?

I'll include it in my next pull request for Renesas media drivers,
either this week or the next.

> ---
>  drivers/media/platform/renesas/vsp1/vsp1_drm.c  | 1 +
>  drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c
> index fe55e8747b05aa351c1547469f9cbbe2b6d25408..15d266439564e2317dbc380ef04d2b15ae899852 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c
> @@ -9,6 +9,7 @@
>  
>  #include <linux/device.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/export.h>
>  #include <linux/slab.h>
>  
>  #include <media/media-entity.h>
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> index 6551d63ba387a05c932d2e557bd0ae5f8810acc7..a754b92232bd57f1b4cd3f9e7903f0b5da5c5c57 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> @@ -13,6 +13,7 @@
>  #include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/export.h>
>  #include <linux/list.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> 
> ---
> base-commit: 642b70d526ab8daa8f256dfc1eb6bf27c3290cc6
> change-id: 20250618-vspx-include-export-84379a99bf59

-- 
Regards,

Laurent Pinchart