Re: [PATCH] fs_context: fix parameter name in infofc() macro

[Jan Kara]

On Wed 18-06-25 01:09:27, RubenKelevra wrote:
> The macro takes a parameter called "p" but references "fc" internally.
> This happens to compile as long as callers pass a variable named fc,
> but breaks otherwise. Rename the first parameter to “fc” to match the
> usage and to be consistent with warnfc() / errorfc().
> 
> Fixes: a3ff937b33d9 ("prefix-handling analogues of errorf() and friends")
> Signed-off-by: RubenKelevra <rubenkelevra@xxxxxxxxx>

Good catch. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  include/linux/fs_context.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/fs_context.h b/include/linux/fs_context.h
> index a19e4bd32e4d..7773eb870039 100644
> --- a/include/linux/fs_context.h
> +++ b/include/linux/fs_context.h
> @@ -200,7 +200,7 @@ void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt,
>   */
>  #define infof(fc, fmt, ...) __logfc(fc, 'i', fmt, ## __VA_ARGS__)
>  #define info_plog(p, fmt, ...) __plog(p, 'i', fmt, ## __VA_ARGS__)
> -#define infofc(p, fmt, ...) __plog((&(fc)->log), 'i', fmt, ## __VA_ARGS__)
> +#define infofc(fc, fmt, ...) __plog((&(fc)->log), 'i', fmt, ## __VA_ARGS__)
>  
>  /**
>   * warnf - Store supplementary warning message
> -- 
> 2.49.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR