Re: [PATCH v3] printk: ringbuffer: Add KUnit test
From: Petr Mladek
Date: Wed Jun 18 2025 - 11:21:27 EST
On Tue 2025-06-17 17:03:13, Petr Mladek wrote:
> On Thu 2025-06-12 08:29:07, Thomas Weißschuh wrote:
> > The KUnit test validates the correct operation of the ringbuffer.
> > A separate dedicated ringbuffer is used so that the global printk
> > ringbuffer is not touched.
> >
> > Co-developed-by: John Ogness <john.ogness@xxxxxxxxxxxxx>
> > Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
>
> Looks good to me:
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
> Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
JFYI, the patch has been comitted into printk/linux.git,
branch rework/ringbuffer-kunit-test.
I am going to get it into the mainline in the next merge window
for 6.17.
> PS: I have got an idea to count the number of failed prb_reserve()
> calls. And it really failed from time to time.
>
> I played with it and came up with two more patches. I am going
> to send them tomorrow. I think that we should solve it separately
> to avoid too many respins. The current patch is very good as
> it is now.
I did not have much time to play with it today. I still have to
think about it...