Re: [PATCH AUTOSEL 6.15 101/110] ALSA: seq: Remove unused snd_seq_queue_client_leave_cells

[Sasha Levin]

On Sun, Jun 01, 2025 at 11:51:02PM +0000, Dr. David Alan Gilbert wrote:
> * Sasha Levin (sashal@xxxxxxxxxx) wrote:
>
> Hi Sasha,
>
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >
> > [ Upstream commit 81ea9e92941091bb3178d49e63b13bf4df2ee46b ]
> >
> > The last use of snd_seq_queue_client_leave_cells() was removed in 2018
> > by
> > commit 85d59b57be59 ("ALSA: seq: Remove superfluous
> > snd_seq_queue_client_leave_cells() call")
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > Link: https://patch.msgid.link/20250502235219.1000429-4-linux@xxxxxxxxxxx
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >
> > NO This commit should not be backported to stable kernel trees for
> > several reasons:
>
> I'd agree with that big fat NO - unless it makes your life easier backporting
> a big pile of other stuff.
> I'm a bit curious about:
>  a) How it got picked up by autosel - I'm quite careful not to include
>     'fixes' tags to avoid them getting picked up.

autosel does it's analysis based on LLMs rather than just commit tags.

>  b) Given it's got a big fat no, why is it posted here?

I was trying to be too smart :)

My scripts got confused by the "YES" later on in the explanation.

Now dropped!

--
Thanks,
Sasha