Re: [PATCH v7 1/5] KVM: arm64: Rename symbols to reflect whether CMO may be used

From: Catalin Marinas
Date: Wed Jun 18 2025 - 10:39:19 EST


On Wed, Jun 18, 2025 at 06:55:37AM +0000, ankita@xxxxxxxxxx wrote:
> -static bool kvm_is_device_pfn(unsigned long pfn)
> +static bool kvm_can_use_cmo_pfn(unsigned long pfn)
> {
> - return !pfn_is_map_memory(pfn);
> + return pfn_is_map_memory(pfn);
> }

I wonder, why not just use pfn_is_map_memory() directly? At a quick
grep, it's only used in one place and your patches don't seem to modify
this function further.

--
Catalin