Re: [PATCH net-next v8 4/6] net: usb: lan78xx: port link settings to phylink API

[Russell King (Oracle)]

On Wed, Jun 18, 2025 at 02:26:00PM +0200, Oleksij Rempel wrote:
> Refactor lan78xx_get_link_ksettings and lan78xx_set_link_ksettings to
> use the phylink API (phylink_ethtool_ksettings_get and
> phylink_ethtool_ksettings_set) instead of directly interfacing with the
> PHY. This change simplifies the code and ensures better integration with
> the phylink framework for link management.
> 
> Additionally, the explicit calls to usb_autopm_get_interface() and
> usb_autopm_put_interface() have been removed. These were originally
> needed to manage USB power management during register accesses. However,
> lan78xx_mdiobus_read() and lan78xx_mdiobus_write() already handle USB
> auto power management internally, ensuring that the interface remains
> active when necessary. Since there are no other direct register accesses
> in these functions that require explicit power management handling, the
> extra calls have become redundant and are no longer needed.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!