Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

[Simon Horman]

On Tue, Jun 17, 2025 at 08:07:37PM +0000, David Thompson wrote:
> > -----Original Message-----
> > From: Simon Horman <horms@xxxxxxxxxx>
> > Sent: Monday, June 16, 2025 8:45 AM
> > To: David Thompson <davthompson@xxxxxxxxxx>
> > Cc: andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> > kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; u.kleine-koenig@xxxxxxxxxxxx;
> > netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Asmaa Mnebhi
> > <asmaa@xxxxxxxxxx>
> > Subject: Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
> > available
> > 
> > On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> > > The message "Error getting PHY irq. Use polling instead"
> > > is emitted when the mlxbf_gige driver is loaded by the kernel before
> > > the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ
> > > fails since it is not yet available. The driver probe() must return
> > > -EPROBE_DEFER if acpi_dev_gpio_irq_get_by() returns the same.
> > >
> > > Signed-off-by: David Thompson <davthompson@xxxxxxxxxx>
> > > Reviewed-by: Asmaa Mnebhi <asmaa@xxxxxxxxxx>
> > 
> > Thanks David,
> > 
> > I as a bug fix this needs a Fixes tag, which you can add by simply replying to this
> > email.
> > 
> > Else we can treat it as an enhancement for net-next.
> 
> Yes, good point Simon.
> 
> This patch is a fix, so should have the following Fixes tag:
> 	Fixes: 6c2a6ddca763 ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")

Thanks David,

I notice that in the meantime that this has been marked as Changes Requested
in patchwork. Presumably due to my earlier comment about a Fixes tag.

Could you post a v2 with the Fixes tag?

Feel free to also include
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>