Re: [PATCH] net-next: gianfar: Use device_get_named_child_node_count()

From: Matti Vaittinen
Date: Wed Jun 18 2025 - 08:25:21 EST


On 18/06/2025 13:42, Simon Horman wrote:
On Tue, Jun 17, 2025 at 02:47:10PM +0300, Andy Shevchenko wrote:
On Tue, Jun 17, 2025 at 01:58:26PM +0300, Matti Vaittinen wrote:
We can avoid open-coding the loop construct which counts firmware child
nodes with a specific name by using the newly added
device_get_named_child_node_count().

The gianfar driver has such open-coded loop. Replace it with the
device_get_child_node_count_named().

Just a side note: The net-next is assumed to be in the square brackets, so when
you format patch, use something like

git format-patch --subject-prefix="PATCH, net-next" ...

Hi Matti,

It looks like this patch has been marked as Changes Requested in patchwork.

Thanks for the heads-up. I don't really follow the patchwork.

I assume because of Andy's comment above.

Could you address that and submit a v2?

Right. I'll re-spin with different subject.

Yours,
-- Matti