Re: [PATCH net-next v2] net: ti: icssg-prueth: Add prp offload support to ICSSG driver

[Simon Horman]

On Tue, Jun 17, 2025 at 03:48:37PM +0530, Himanshu Mittal wrote:
> Add support for ICSSG PRP mode which supports offloading of:
>  - Packet duplication and PRP trailer insertion
>  - Packet duplicate discard and PRP trailer removal
> 
> Signed-off-by: Himanshu Mittal <h-mittal1@xxxxxx>
> ---
> v2-v1:
> - Align with recent firmware name handling updates made in:
>  https://lore.kernel.org/all/20250613064547.44394-1-danishanwar@xxxxxx/
> 
> v1: https://lore.kernel.org/all/42ac0736-cb5a-4d99-a11c-6f861adbdb5f@xxxxxx/

...

> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h

...

> @@ -349,6 +352,7 @@ struct prueth {
>  	struct icssg_firmwares icssg_emac_firmwares[PRUETH_NUM_MACS];
>  	struct icssg_firmwares icssg_switch_firmwares[PRUETH_NUM_MACS];
>  	struct icssg_firmwares icssg_hsr_firmwares[PRUETH_NUM_MACS];
> +	struct icssg_firmwares icssg_prp_firmwares[PRUETH_NUM_MACS];
>  };

Hi Himanshu,

Please also add icssg_prp_firmwares to the Kernel doc for struct preth,
which appears a little above this hunk.

Flagged by ./scripts/kernel-doc -none

Otherwise, this patch looks good to me.

-- 
pw-bot: changes-requested