Re: [PATCH] fs/buffer: fix comments to reflect logical block size

[Pankaj Raghav (Samsung)]

On Tue, Jun 17, 2025 at 09:48:50PM -0400, Martin K. Petersen wrote:
> 
> Hi Pankaj!
> 
> > -	/* Size must be multiple of hard sectorsize */
> > +	/* Size must be multiple of logical block size */
> >  	if (unlikely(size & (bdev_logical_block_size(bdev)-1) ||
> >  			(size < 512 || size > PAGE_SIZE))) {
> >  		printk(KERN_ERR "getblk(): invalid block size %d requested\n",
> 
> OK with me. However, maybe that comment should just go away? The code on
> the following line articulates the constraint very clearly.
> 
> If you tweak things, please fix the spacing for "(bdev)-1".

That makes sense. I will send a v2.
> 
> Either way:
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> 

Thanks
> -- 
> Martin K. Petersen

-- 
Pankaj Raghav