Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh_ops
From: Christoph Hellwig
Date: Wed Jun 18 2025 - 01:39:08 EST
On Tue, Jun 17, 2025 at 11:22:39PM -0500, Timothy Pearson wrote:
> /* Platform dependent EEH operations */
> struct eeh_ops *eeh_ops = NULL;
> +EXPORT_SYMBOL(eeh_ops);
Exporting ops vectors is generally a really bad idea. Please build a
proper abstraction instead.
And use EXPORT_SYMBOL_GPL for any kind of low-level API.