Re: [PATCH v5 2/3] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers

[Andrew Ijano]

On Sat, Jun 14, 2025 at 4:33 PM Andrew Ijano <andrew.ijano@xxxxxxxxx> wrote:
>
> On Thu, Jun 12, 2025 at 4:29 AM Nuno Sá <noname.nuno@xxxxxxxxx> wrote:
...
> >
> > Unless I'm missing something, the above seems unrelated to the rest of the patch.
> >
> Oh, I can see why that might feel unrelated. Actually, this was
> related to the first version of the patch which was focused on
> removing the duplicated behavior of sca3000_read_data() and
> sca3000_read_data_short(), unifying it in only one function. Also,
> with Andy's suggestions we cleaned up the function as you're seeing
> here. However, we later replaced all usages of
> sca3000_read_data_short() by spi helpers, leaving just one place
> calling sca3000_read_data(), so this change isn't as necessary as
> before.
>
> Do you think it's still a valid cleanup for this patch or would you
> prefer moving it to a separated one?

Looking back to this, I think we really could benefit from having two
separate patches to handle these different changes.
I'll try to make a new version that addresses all the comments for the
current patchset.

Thanks,
Andrew