Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver

[Armin Wolf]

Am 16.06.25 um 14:46 schrieb Werner Sembach:

> Hi, small additon
>
> Am 15.06.25 um 19:59 schrieb Armin Wolf:
> > +        functionality.
> > +
> > +What: 
> > /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation
> > +Date:        Juni 2025
> > +KernelVersion:    6.17
> > +Contact:    Armin Wolf <W_Armin@xxxxxx>
> > +Description:
> > +        Forces the integrated lightbar to display a rainbow 
> > animation when the machine
> > +        is not suspended. Writing "enable"/"disable" into this file 
> > enables/disables
> > +        this functionality.
> > +
> > +        Reading this file returns the current status of the rainbow 
> > animation functionality.
> > +
> > +What: 
> > /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend
> > +Date:        Juni 2025
> > +KernelVersion:    6.17
> > +Contact:    Armin Wolf <W_Armin@xxxxxx>
> > +Description:
> > +        Causes the integrated lightbar to display a breathing 
> > animation when the machine
> > +        has been suspended and is running on AC power. Writing 
> > "enable"/"disable" into
> > +        this file enables/disables this functionality.
> > +
> > +        Reading this file returns the current status of the 
> > breathing animation
> > +        functionality.
>
> maybe this would be better under the /sys/class/leds/*/ tree if possible

I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers.

Thanks,
Armin Wolf