Re: [PATCH net v1] netmem: fix skb_frag_address_safe with unreadable skbs

From: Stanislav Fomichev
Date: Tue Jun 17 2025 - 17:30:21 EST


On 06/17, Mina Almasry wrote:
> On Tue, Jun 17, 2025 at 2:09 PM Mina Almasry <almasrymina@xxxxxxxxxx> wrote:
> >
> > skb_frag_address_safe() needs a check that the
> > skb_frag_page exists check similar to skb_frag_address().
> >
> > Cc: ap420073@xxxxxxxxx
> >
>
> Sorry, I realized right after hitting send, I'm missing:
>
> Fixes: 9f6b619edf2e ("net: support non paged skb frags")
>
> I can respin after the 24hr cooldown.

The function is used in five drivers, none of which support devmem tx,
does not look like there is a reason to route it via net.

The change it self looks good, but not really sure it's needed.
skb_frag_address_safe is used in some pass-data-via-descriptor-ring mode,
I don't see 'modern' drivers (besides bnxt which added this support in 2015)
use it.