Re: [RFC PATCH 1/3] platform/x86: Add Uniwill WMI driver

[Armin Wolf]

Am 15.06.25 um 21:05 schrieb ALOK TIWARI:

> On 15-06-2025 23:29, Armin Wolf wrote:
> > +#define UNIWILL_OSD_SILENT_MODE_ON 0x06
> > +#define UNIWILL_OSD_SILENT_MODE_OFF        0x07
> > +
> > +#define UNIWILL_OSD_WLAN_ON            0x08
> > +#define UNIWILL_OSD_WLAN_OFF            0x09
> > +
> > +#define UNIWILL_OSD_WIMAX_ON            0x0A
> > +#define UNIWILL_OSD_WIMAX_OFF            0x0B
> > +
> > +#define UNIWILL_OSD_BLUETOOTH_ON        0x0C
> > +#define UNIWILL_KEY_BLUETOOTH_OFF        0x0D
>
> why this is UNIWILL_KEY_BLUETOOTH_OFF
> not UNIWILL_OSD_BLUETOOTH_OFF typo ?

Good catch, this should indeed have been UNIWILL_OSD_BLUETOOTH_OFF.

Thanks,
Armin Wolf

> > +
> > +#define UNIWILL_OSD_RF_ON            0x0E
> > +#define UNIWILL_OSD_RF_OFF            0x0F
> > +
> > +#define UNIWILL_OSD_3G_ON            0x10
> > +#define UNIWILL_OSD_3G_OFF            0x11
> > +
> > +#define UNIWILL_OSD_WEBCAM_ON            0x12
> > +#define UNIWILL_OSD_WEBCAM_OFF            0x13
>
>
> Thanks,
> Alok