Re: [PATCH 0/2] Add nokbdwakeup quirk and enable it for MSI Claw

[Dmitry Torokhov]

Hi Matthew,

On Mon, Jun 16, 2025 at 10:19:28PM -0700, Matthew Schwartz wrote:
> This patch series aims to solve an issue on the MSI Claw, a series of
> handheld gaming PCs, where their volume buttons will wake the system out
> of s2idle because they are registered via an i8042 keyboard device. This
> is not expected behavior on a handheld device that lacks an actual
> keyboard, as it is very easy to press the volume buttons while handling
> the device in its suspended state. 
> 
> To solve this, introduce a new quirk based on DMI match that will disable
> the wakeup property of an i8042 keyboard device and enable it for current
> MSI Claw models.

Why does this need to be done in kernel instead of having a udev rule
to toggle this through sysfs:

/sys/devices/platform/i8042/serio0/power/wakeup

Thanks.

-- 
Dmitry