Re: [PATCH 0/2] Simplify the shash wrappers for the CRC32 library

From: David Sterba
Date: Tue Jun 17 2025 - 16:19:48 EST


On Fri, Jun 13, 2025 at 11:37:51AM -0700, Eric Biggers wrote:
> This series simplifies how the CRC32 library functions are exposed
> through the crypto_shash API. We'll now have just one shash algorithm
> each for "crc32" and "crc32c", and their driver names will just always
> be "crc32-lib" and "crc32c-lib" respectively. This seems to be all
> that's actually needed.
>
> As mentioned in patch 2, this does change the content of
> /sys/fs/btrfs/$uuid/checksum again, but that should be fine.

Yes, this is fine, I don't think any ABI applies here and the
implementation was only informative.

> This is based on v6.16-rc1, and I'm planning to take these patches
> through the crc-next tree. These supersede
> https://lore.kernel.org/r/20250601224441.778374-2-ebiggers@xxxxxxxxxx/
> and
> https://lore.kernel.org/r/20250601224441.778374-3-ebiggers@xxxxxxxxxx/,
> and they fix the warning in the full crypto self-tests reported at
> https://lore.kernel.org/r/aExLZaoBCg55rZWJ@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
>
> Eric Biggers (2):
> btrfs: stop parsing crc32c driver name
> crypto/crc32[c]: register only "-lib" drivers

Acked-by: David Sterba <dsterba@xxxxxxxx>

Thanks.