RE: [PATCH v1] gpio: mlxbf3: only get IRQ for device instance 0
From: David Thompson
Date: Tue Jun 17 2025 - 16:17:35 EST
> -----Original Message-----
> From: Bartosz Golaszewski <brgl@xxxxxxxx>
> Sent: Monday, June 16, 2025 3:59 AM
> To: David Thompson <davthompson@xxxxxxxxxx>
> Cc: linus.walleij@xxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Shravan Ramani <shravankr@xxxxxxxxxx>
> Subject: Re: [PATCH v1] gpio: mlxbf3: only get IRQ for device instance 0
>
> On Fri, Jun 13, 2025 at 6:35 PM David Thompson <davthompson@xxxxxxxxxx>
> wrote:
> >
> > The gpio-mlxbf3 driver interfaces with two GPIO controllers, device
> > instance 0 and 1. There is a single IRQ resource shared between the
> > two controllers, and it is found in the ACPI table for device instance
> > 0. The driver should not attempt to get an IRQ resource when probing
> > device instance 1, otherwise the following error is logged:
> > mlxbf3_gpio MLNXBF33:01: error -ENXIO: IRQ index 0 not found
> >
> > Signed-off-by: David Thompson <davthompson@xxxxxxxxxx>
> > Reviewed-by: Shravan Kumar Ramani <shravankr@xxxxxxxxxx>
> > ---
>
> This looks like a fix, does it miss the Fixes: and Cc: stable tags?
>
> Bartosz
Hello Bartosz,
Yes, good point. Since this patch is a fix, it should have the following tag:
Fixes: cd33f216d241 ("gpio: mlxbf3: Add gpio driver support")
Do you want me to create a v2 with the above Fixes tag and send out,
this time including to CC:stable@xxxxxxxxxxxxxxx?
Regards, Dave