Re: NULL pointer dereference in igen6_probe - 6.16-rc2

[Borislav Petkov]

On Tue, Jun 17, 2025 at 04:16:41PM +0000, Zhuo, Qiuxu wrote:
> The maximum number of detected memory controllers is bounded
> by the macro NUM_IMC [1]. This value is what we know as the maximum 
> possible value now.

I don't think you're answering my question:

Can this happen in real life and why was it added?

        if (lmc < res_cfg->num_imc) 
                igen6_printk(KERN_WARNING, "Expected %d mcs, but only %d detected.",
                             res_cfg->num_imc, lmc);

/me does git archeology...

Aha, I guess it can even with Intel and official fw and so on - not only
coreboot:

20e190b1c1fd ("EDAC/igen6: Skip absent memory controllers")

> I'll make a patch for Marek to test first. 

Yes, that would be the right thing to do.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette