Re: [PATCH v4 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format

[Andrew Lunn]

On Tue, Jun 17, 2025 at 01:09:21PM -0300, Fabio Estevam wrote:
> On Mon, Jun 16, 2025 at 3:48 PM Frank Li <Frank.Li@xxxxxxx> wrote:
> 
> > +examples:
> > +  - |
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ethernet@0 {
> > +            compatible = "qca,qca7000";
> > +            reg = <0x0>;
> > +            interrupt-parent = <&gpio3>;      /* GPIO Bank 3 */
> > +            interrupts = <25 0x1>;            /* Index: 25, rising edge */
> > +            spi-cpha;                         /* SPI mode: CPHA=1 */
> > +            spi-cpol;                         /* SPI mode: CPOL=1 */
> > +            spi-max-frequency = <8000000>;    /* freq: 8 MHz */
> 
> All of these comments are obvious and don't bring any new information.
> 
> I recommend dropping all of them.

I would also suggest replacing 0x1 with IRQ_TYPE_EDGE_RISING.

  Andrew