Re: [PATCH v9 0/4] leds: add new LED driver for TI LP5812

From: Nam Tran
Date: Tue Jun 17 2025 - 11:40:46 EST


On Wed, 11 Jun 2025, Krzysztof Kozlowski wrote:

> On 10/06/2025 19:43, Nam Tran wrote:
> > This patch series adds support for the TI/National Semiconductor LP5812
> > 4x3 matrix RGB LED driver. The driver supports features such as autonomous
> > animation and time-cross-multiplexing (TCM) for dynamic LED effects.
> >
> > Following feedback from both the LED and auxdisplay subsystem maintainers,
> > the driver has been moved back to the LED subsystem, under drivers/leds/rgb/.
> > This version integrates with the existing multicolor LED APIs, avoiding custom
> > sysfs where standard LED interfaces are sufficient.
> >
> > Signed-off-by: Nam Tran <trannamatk@xxxxxxxxx>
> > ---
> > Changes in v9:
> > - Move driver back to drivers/leds/rgb/
> > - Integrate with LED multicolor framework
> > - Refactor and simplify custom sysfs handling
> > - Extend Device Tree binding to support multi-led@ nodes using leds-class-multicolor.yaml
>
> You need to provide reason why you dropped reviews.

In v9, the Device Tree binding was restructured to integrate with the standard
leds-class-multicolor.yaml schema and support multi-led@ nodes with nested led@
subnodes. This change introduced a new patternProperties hierarchy and removed
the previous flat led@ layout used in the earlier versions.

Due to this substantial structural change — even though the intent and top-level
properties remained similar — I decided to drop the Reviewed-by tag to avoid
misrepresenting prior review coverage.

I will include this explanation in the changelog of the next version (v10).

Best regards,
Nam Tran