Re: [PATCH v3 1/2] rust: Introduce file_from_location()

[Miguel Ojeda]

On Tue, Jun 17, 2025 at 3:42 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> Will do, one thing though: the comment lines seem to wrap at 78 or 80
> chars, so do other lines for conditional features in rust/kernel/lib.rs.
> However I believe in Rust code we use 100 chars text width, any
> particular reason that I should keep these new lines the same (wrapping
> at 80 characters)? Otherwise I will make the new lines wrap at 100.

We have both styles, so up to you.

It would have been nice to at least know already if `rustfmt` would
eventually land on 80 or 100 for this, even if the automatically
wrapping is not stable :(

> Sure, will do, but I'm afraid there is only case, unless I misunderstood
> you:

I meant the "If `file_with_nul()` is not available" vs. the available
one (since it is mentioned in the docs already).

> /// use kernel::file_from_location;

I would hide this line, since it is a single import of the item itself.

> ///     pr_info!("{}\n", file_from_location(caller));

I would suggest adding a comment on top of this line mentioning the
output it could potentially show, e.g.

    // Output: ...

Thanks for this!

Cheers,
Miguel