Re: [PATCH] function_graph: Fix off-by-one error in buffer size

From: Steven Rostedt
Date: Tue Jun 17 2025 - 11:05:04 EST


On Tue, 17 Jun 2025 11:00:17 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 17 Jun 2025 11:19:06 +0000
> Artem Sadovnikov <a.sadovnikov@xxxxxxxxx> wrote:
>
> > The comment above buffer mentions sign, 10 bytes width for number and null
> > terminator, but buffer itself isn't large enough to hold that much data.
> >
> > This is a cosmetic change, since PID cannot be negative, other than -1.
>
> Right, where I'll change the subject as that makes it look like this is a
> real bug.

Can your resend and Cc linux-trace-kernel@xxxxxxxxxxxxxxx otherwise it will
not get into the patchwork queue.

Rename the Subject to:

fgraph: Make pid_str size match the comment

Thanks!

-- Steve