Re: [PATCH 20/43] sched/smp: Make SMP unconditional

[Steven Rostedt]

On Tue, 17 Jun 2025 06:43:00 +0200
Francesco Ansanelli <francians@xxxxxxxxx> wrote:

> I hope this is the right way of reaching you.
> I was reviewing the patch in subject and noticed a possible error:
> 
> -#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) &&
> \
> - (defined(CONFIG_SMP) || defined(CONFIG_CFS_BANDWIDTH)))
> +#if defined(CONFIG_RT_GROUP_SCHED) || defined(CONFIG_FAIR_GROUP_SCHED)
> 
> I think it should be:
> 
> +#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) &&
> defined(CONFIG_CFS_BANDWIDTH))

Nope, it was right as is. The "Make SMP unconditional" means CONFIG_SMP is
now always defined. The original was:

#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) && \
 (defined(CONFIG_SMP) || defined(CONFIG_CFS_BANDWIDTH)))

With defined(CONFIG_SMP) always true, the:

  (defined(CONFIG_SMP) || defined(CONFIG_CFS_BANDWIDTH))

is always true as well, which makes it:

#if defined(CONFIG_RT_GROUP_SCHED) || (defined(CONFIG_FAIR_GROUP_SCHED) && (true))

Or just:

#if defined(CONFIG_RT_GROUP_SCHED) || defined(CONFIG_FAIR_GROUP_SCHED)

-- Steve