Re: [PATCH 1/1] sched/deadline: Fix fair_server runtime calculation formula
From: Juri Lelli
Date: Tue Jun 17 2025 - 10:24:49 EST
On 17/06/25 16:14, Peter Zijlstra wrote:
> On Tue, Jun 17, 2025 at 02:33:15PM +0200, Juri Lelli wrote:
...
> > To me it looks like we want this (no scaling) for fair_server (and
> > possibly scx_server?) as for them we are only looking into a 'fixed
> > time' type of isolation. Full fledged servers (hierarchical scheduling)
> > maybe have it configurable, or enabled by default as a start (as we have
> > it today).
>
> Right. Then we should write the above like:
>
> scaled_delta_exec = delta_exec;
> if (!dl_se->dl_server)
> scaled_delta_exec = dl_scaled_delta_exec(rq, dl_se, delta_exec);
>
> and let any later server users add bits on if they want more options.
Works for me. Looks cleaner also.
Kuyo, can you please update your patch then?
Thanks,
Juri