Re: [PATCH net-next v3 4/4] netdevsim: account dropped packet length in stats on queue free

[Jakub Kicinski]

On Tue, 17 Jun 2025 01:19:00 -0700 Breno Leitao wrote:
> -static void nsim_queue_free(struct nsim_rq *rq)
> +static void nsim_queue_free(struct net_device *dev, struct nsim_rq *rq)
>  {
>  	hrtimer_cancel(&rq->napi_timer);
> +	dev_dstats_rx_dropped_add(dev, rq->skb_queue.qlen);

here we are in process context and debug checks complain about the use
of this_cpu_ptr(). Let's wrap this in local_bh_disable() / enable() ?

>  	skb_queue_purge_reason(&rq->skb_queue, SKB_DROP_REASON_QUEUE_PURGE);
>  	kfree(rq);
>  }
-- 
pw-bot: cr