Re: [PATCH v1 1/3] cgroup: add lock guard support for cgroup_muetx

[Michal Koutný]

(typo in subject)

On Sat, Jun 07, 2025 at 12:18:39AM +0800, Jemmy Wong <jemmywong512@xxxxxxxxx> wrote:
...
> @@ -5489,14 +5488,14 @@ static void css_free_rwork_fn(struct work_struct *work)
>  	}
>  }
>  
> -static void css_release_work_fn(struct work_struct *work)
> +static inline void css_release_work_fn_locked(struct work_struct *work)
>  {
>  	struct cgroup_subsys_state *css =
>  		container_of(work, struct cgroup_subsys_state, destroy_work);
>  	struct cgroup_subsys *ss = css->ss;
>  	struct cgroup *cgrp = css->cgroup;
>  
> -	cgroup_lock();
> +	guard(cgroup_mutex)();

I think this should use different name suffix than _locked to
distinguish it from traditional _locked functions that expect a lock
being held. E.g. *_locking? or __* (like __cgroup_task_count()).

Attachment: signature.asc
Description: PGP signature