Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Add CPU scaling clock node

[Taniya Das]

On 6/17/2025 12:59 PM, Imran Shaik wrote:
> 
> 
> On 6/17/2025 12:27 PM, Taniya Das wrote:
>>
>>
>> On 6/13/2025 6:40 PM, Dmitry Baryshkov wrote:
>>> On Thu, Jun 12, 2025 at 03:47:21PM +0530, Taniya Das wrote:
>>>> Add cpufreq-hw node to support CPU frequency scaling.
>>>>
>>>> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/qcs615.dtsi | 29 +++++++++++++++++++++++++++++
>>>>  1 file changed, 29 insertions(+)
>>>>
>>>> +
>>>> +		cpufreq_hw: cpufreq@18323000 {
>>>> +			compatible = "qcom,sc7180-cpufreq-hw", qcom,cpufreq-hw";
>>>
>>> This wasn't build-tested (or was edited after being compile-tested).
>>
>> This is already tested on the QCS615.
>>>
> 
> Seems there is a syntax issue, could you please check?
>  
> - compatible = "qcom,sc7180-cpufreq-hw", qcom,cpufreq-hw";
> + compatible = "qcom,sc7180-cpufreq-hw", "qcom,cpufreq-hw";

Yeah, it was edited. Thanks, will fix it in the next patch.
> 
>>>> +			reg = <0 0x18323000 0 0x1400>, <0 0x18325800 0 0x1400>;
>>>> +			reg-names = "freq-domain0", "freq-domain1";
>>>> +
>>>> +			clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>;
>>>> +			clock-names = "xo", "alternate";
>>>> +
>>>> +			#freq-domain-cells = <1>;
>>>> +			#clock-cells = <1>;
>>>> +		};
>>>> +
>>>>  	};
>>>>  
>>>>  	arch_timer: timer {
>>>>
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>
>