Re: [PATCH 1/1] mm/madvise: initialize prev pointer in madvise_walk_vmas

[David Hildenbrand]

> > > > 	vma = vma_modify_flags_name(&vmi, *prev, ...
> > > >
> > > > We should use Fixes: then.
> > >
> > > So no we shouldn't...
> > >
> > > > Acked-by: David Hildenbrand <david@xxxxxxxxxx>
> > >
> > > Sure? :)
> >
> > Unless I am missing something important, yes :)
>
> This solution isn't correct as prev == NULL when prev != NULL is wholly
> incorrect.

I am not able to understand what you mean :)

I assume you mean, that we reach a point down in the callchain, where 
"prev" is supposed to be set to something proper, but it would be "NULL".

That would indeed require a different fix.

I wonder why we didn't trigger this case so far?

--
Cheers,

David / dhildenb