Re: [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging

[John Garry]

On 16/06/2025 19:19, Alok Tiwari wrote:
> Fix an error in nvme_log_err_passthru() where cdw14 was incorrectly
> printed twice instead of cdw15. This fix ensures accurate logging of
> the full passthrough command payload.
>
> Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx>
> ---
> Is it ok to keep Fixes tag for this fix?
> ---
>   drivers/nvme/host/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 92697f98c601..f3e07cb92385 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -386,7 +386,7 @@ static void nvme_log_err_passthru(struct request *req)
>   		nr->cmd->common.cdw12,
>   		nr->cmd->common.cdw13,
>   		nr->cmd->common.cdw14,
> -		nr->cmd->common.cdw14);
> +		nr->cmd->common.cdw15);

Apart from the fix, any reason not to use le32_to_cpu() when getting 
these values? AFAICS, they are __le32 type

>   }
>   
>   enum nvme_disposition {