Re: [PATCH] ASoC: wm8524: Remove the constraints of rate

[Shengjiu Wang]

On Fri, Jun 13, 2025 at 7:21 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Jun 13, 2025 at 11:52:16AM +0800, Shengjiu Wang wrote:
>
> > WM8524 is a codec which can only work in slave mode, the bit clock and
> > frame sync clock are from cpu dai, if there is any constraint, the
> > constraint should be from cpu dai, no need to add constraint in codec
> > side.
>
> No, there is a need here - the constraint is enforcing that the ratio
> between the MCLK and sample rate is within spec which is a common
> requirement for audio performance.
>
> > On the other hand, with the constraint of rate in codec requires the
> > sysclk to be fixed, which brings unnecessary limitations on sound card
> > usage.
>
> A common pattern is to only enforce constraints once a sysclk is
> configured.

Thanks for the comments, I will update the commit to only enable
constraints when sysclk is available.

Best regards
Shengjiu Wang