Re: [PATCH v6 3/8] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms

From: Praveen Talari
Date: Mon Jun 16 2025 - 21:53:22 EST




On 6/17/2025 12:06 AM, Bryan O'Donoghue wrote:
On 16/06/2025 09:40, Praveen Talari wrote:
Hi Bryan,

Gentle reminder!!

Thanks,
Praveen talari

Small nitpick here.

1. You didn't include me in your v6 CC list so the ping
   is the first direct notification of this series I've received.
   This is no problem BTW just for your reference.

2. Again as a general recommendation to qcom folks the commit
   overview logs are fine but please include the name of the person
   whose feedback you are addressing in that log.

eg

v5 -> v6

- replaced dev_err with dev_err_probe - Bryan

etc, that way a reviewer can re-up their context quicker.

Thanks you for your valuable inputs. I will ensure it is reflected in the next patch set onwards.

Thanks,
Praveen Talari


---
bod